Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make req-dev include req-tests and add requests explicitly to req-tests #284

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

hategan
Copy link
Collaborator

@hategan hategan commented Sep 15, 2022

This should address #283.

@wilke, can you try setting up the tests with this branch?

@hategan hategan requested a review from wilke September 15, 2022 21:24
Copy link
Collaborator

@jameshcorbett jameshcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, FWIW.

@wilke wilke self-assigned this Sep 15, 2022
@wilke
Copy link
Collaborator

wilke commented Sep 15, 2022

Command: ./psij-ci-run
Status: OK

Tests are running and i installed the requirements with python -m pip install --target .packages --upgrade -r requirements-dev.txt

There is one error message at build time:

ERROR: After October 2020 you may experience errors when installing or updating packages. This is because pip will change the way that it resolves dependency conflicts.

We recommend you use --use-feature=2020-resolver to test your packages with the new resolver before it becomes the default.

sphinx-tabs 3.4.1 requires docutils~=0.18.0, but you'll have docutils 0.17.1 which is incompatible.

@wilke wilke merged commit 940906a into main Sep 21, 2022
@wilke wilke deleted the updated_requirements_to_include_requests branch September 21, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants