Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting up CI matrix for pip llnl #192

Merged
merged 47 commits into from
Aug 4, 2023
Merged

Splitting up CI matrix for pip llnl #192

merged 47 commits into from
Aug 4, 2023

Conversation

MishaZakharchanka
Copy link
Collaborator

This PR focuses on the pip CI for LLNL machines. The functionality of the tests remains the same, but the jobs will now be listed individually on gitlab. Additionally, there was organizational work done in an attempt to make the file more readable and maintainable.

@MishaZakharchanka
Attempting to split setup jobs
dbbd338
@MishaZakharchanka
Extending/fixing/simplifying test jobs
cf9d011
@MishaZakharchanka
More abstraction
986a957
@MishaZakharchanka
Trying to fix unknown key error
1ea8f7a
@MishaZakharchanka
Trying to fix variable syntax
3ec1f57
@MishaZakharchanka
Fixing syntax issues
befc8e1
@MishaZakharchanka
Moving variables under correct key
ae17056
@MishaZakharchanka
Adding cleanup
7a71b94
@MishaZakharchanka
Missed an extend
a4b8565
@MishaZakharchanka
getting rid of job_tag abstraction
a2b2416
@MishaZakharchanka
Turning variable into string
4e81b37
@MishaZakharchanka
Removing a layer of abstraction that might not be necessary
b402a3e
@MishaZakharchanka
Trying to solve permissions error on build
d1c34ff
@MishaZakharchanka
Adding Runner type var back to try and solve perm error
732edac
@MishaZakharchanka
Removing some of the abstraction because of needed vars
989e1bd
@MishaZakharchanka
Adding var back to setup, using hidden jobs again
0c578f7
@MishaZakharchanka
replacing hyphens with underscores
bb05ab7
@MishaZakharchanka
Adding ruby back
2700676
@MishaZakharchanka
chlarifying job names
e2c07fc
@MishaZakharchanka
Organization and comments
f4014ec
@MishaZakharchanka
Comments on possible changes
bfff359
@MishaZakharchanka
clean up for merge
7bff194
@MishaZakharchanka
Copy link
Collaborator Author

Do we want to add Lassen back to the machines that we are testing on?

@mtitov
Copy link
Collaborator

mtitov commented May 17, 2023

Do we want to add Lassen back to the machines that we are testing on?

Yes.

And can you please investigate having a list of tags for $RUNNER_TYPE, since we need to add tag slurm for Slurm batch-runners (e.g., RUNNER_TYPE: [ "batch", "slurm" ]?)

mtitov
mtitov reviewed May 18, 2023
View reviewed changes
.gitlab/llnl-ci-pip.yml Outdated Show resolved Hide resolved
@MishaZakharchanka

This comment was marked as resolved.

Sign in to view
mtitov
mtitov reviewed May 22, 2023
View reviewed changes
.gitlab/llnl-ci-pip.yml Outdated Show resolved Hide resolved
mtitov
mtitov reviewed May 23, 2023
View reviewed changes
.gitlab/llnl-ci-pip.yml Outdated Show resolved Hide resolved
@mtitov mtitov marked this pull request as ready for review May 24, 2023 22:03
mtitov
mtitov approved these changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

MishaZakharchanka and others added 19 commits June 1, 2023 14:11
@MishaZakharchanka
Changing runner tag, b/c machine updates
ec877b4
@MishaZakharchanka
Specifying lsf RUNNER_TYPE for lassen
4c1c4a4
@MishaZakharchanka
Trying bto revert to batch runner type
dfe87aa
@MishaZakharchanka
Moving Ruby back to batch
36ca978
@MishaZakharchanka
Merge branch 'master' into refactor/llnl-ci-pip
57e74ee
@MishaZakharchanka
Changing last runner tag back to batch
3872427
@MishaZakharchanka
Adding cleanup back
aee3fd2
@MishaZakharchanka
starting CI again
0c3b66a
@MishaZakharchanka
checking pip version
c24b760
@MishaZakharchanka
adding version requirements, and removing debugging prints
934dd86
@MishaZakharchanka
Trying a different gcc
98982ca
@MishaZakharchanka
Looking into what versions of gcc the different systems are using
d93882c
@MishaZakharchanka
Trying clang for lassen CI
7867ab6
@MishaZakharchanka
Adding newer python module
8aaa000
@MishaZakharchanka
Removing Lassen CI attempted fixes
02cc2a5
@MishaZakharchanka
Adding clean up job for quartz
d46b436
@MishaZakharchanka
Trying cleanup on Lassen instead of quartz
e49bbda
@mtitov
ci-pip: fixed dependencies on Lassen
8e14991
@mtitov
ci-conda: synced with pip-pipeline
0acf5fb
@mtitov mtitov merged commit 8a67441 into master Aug 4, 2023
13 of 21 checks passed
@mtitov mtitov deleted the refactor/llnl-ci-pip branch August 4, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtitov mtitov mtitov approved these changes

Assignees

@MishaZakharchanka MishaZakharchanka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MishaZakharchanka @mtitov