EmailList - Change variable names to stop Invoke-Command loop

[natosullivan]

The below code loops indefinitely until the call depth limit is reached:

Email -Port 25 {
        EmailHeader {
            EmailFrom -Address 'test@test.com'
            EmailTo -Addresses "test@test.net"
            EmailServer -Server 'mail.test.com'
            EmailOptions -Priority High -DeliveryNotifications Never
            EmailSubject -Subject 'This is a test email'
        }
        EmailBody -FontFamily 'Calibri' -Size 15 {
            EmailTextBox -FontSize 18 -TextDecoration underline -FontWeight Bold {
                "Test Email"
            }
            EmailText -LineBreak
            EmailList {
                EmailListItem -Text "NotNull"
            }
        }
    } -Supress:$false

Looks to be caused by the script block variables in EmailList and New-HTMLEmailList being named the same, causing the Invoke-Command to create a loop.

Resolved by changing the script block variable name in New-HTMLEmailList to $HTMLListItems

[PrzemyslawKlys]

Changing the variable name without changing params

PSWriteHTML/Public/New-HTMLList.ps1

Line 4 in 4405b7d

[ScriptBlock]$ListItems,

Is going to break that function. The proper fix is to merge New-HTMLList with EmailList by making EmailList an alias. Now that emailimo is merged into PSWriteHTML some stuff is doubled.

[PrzemyslawKlys]

I've tested this by just running the old code and it never returned error but than the email that arrived didn't had that EmailList. I did a test change per your suggestion

And it seems to fix the issue. But I believe we should get rid of EmailList and just make it an alias. Will you fix it?

[natosullivan]

That is a much cleaner way to resolve this, I have added the alias to New-HTMLList.

[PrzemyslawKlys]

Looks good. Thank you