[Model] support VoRA model #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
lmms_eval/models/vora.py:155
- The attribute 'self.task_dict' is used but not defined in the class; please ensure it is properly initialized or passed.
visuals = [doc_to_visual[0](self.task_dict[task][split][ids]) for ids in doc_id]
|
|
||
| @property | ||
| def max_length(self): | ||
| return self._max_length |
There was a problem hiding this comment.
The property 'max_length' returns 'self._max_length', which is not defined anywhere in the class; either initialize it or remove the property.
Copilot uses AI. Check for mistakes.
| for text_outputs, context in zip(answers, contexts): | ||
| res.append(text_outputs) | ||
|
|
||
| self.cache_hook.add_partial("generate_until", (context, gen_kwargs), text_outputs) |
There was a problem hiding this comment.
The attribute 'self.cache_hook' is used without being initialized; please define 'cache_hook' before using it.
Copilot uses AI. Check for mistakes.
dadwadw233
pushed a commit
to dadwadw233/lmms-eval
that referenced
this pull request
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for VoRA, a novel paradigm for transforming an LLM into an MLLM.
Below is a screenshot of the evaluation result on realwordqa task: