refactor(models): (PR 1/4) isolate plugin registration failures - #1446
Draft
Luodian wants to merge 3 commits into
Draft
refactor(models): (PR 1/4) isolate plugin registration failures#1446Luodian wants to merge 3 commits into
Luodian wants to merge 3 commits into
Conversation
This was referenced Aug 23, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes one plugin payload register transactionally and keeps later entry points visible when an earlier one fails. Built-in resolution and lazy backend imports remain unchanged.
Depends on #1440.
GitHub review stack #1468.
Stack
This is review layer 1 of 4. Do not merge this PR; the final collector will land the complete authoritative registry atomically.
Summary
In scope
ModelRegistryV2transaction, listing, and entry-point failure behavior.Out of scope
Validation
python -m pytest -q test/models/test_model_registry_v2.py| sample size:N=18 tests| key metrics:18 passed| result:passpre-commit run --files lmms_eval/models/registry_v2.py test/models/test_model_registry_v2.py| sample size:N=2 files| result:passRisk / Compatibility
force_simpleremain unchanged.Type of Change