Skip to content

refactor(models): (PR 1/4) isolate plugin registration failures - #1446

Draft
Luodian wants to merge 3 commits into
brian/ci/hermetic-eval-contractsfrom
brian/refactor/model-registry-transactions
Draft

refactor(models): (PR 1/4) isolate plugin registration failures#1446
Luodian wants to merge 3 commits into
brian/ci/hermetic-eval-contractsfrom
brian/refactor/model-registry-transactions

Conversation

@Luodian

@Luodian Luodian commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

This makes one plugin payload register transactionally and keeps later entry points visible when an earlier one fails. Built-in resolution and lazy backend imports remain unchanged.

Depends on #1440.

GitHub review stack #1468.

Stack

This is review layer 1 of 4. Do not merge this PR; the final collector will land the complete authoritative registry atomically.

Summary

  • Register one or many manifests through copy-then-commit state.
  • Return structured failures per entry point and continue loading later plugins.
  • Preserve strict conflicts and explicit overwrite behavior.

In scope

  • ModelRegistryV2 transaction, listing, and entry-point failure behavior.
  • Focused rollback, conflict, and isolation tests.

Out of scope

  • Global startup, compatibility views, and discovery consumers are later review layers.
  • This layer is not an independently mergeable release unit.

Validation

  • python -m pytest -q test/models/test_model_registry_v2.py | sample size: N=18 tests | key metrics: 18 passed | result: pass
  • pre-commit run --files lmms_eval/models/registry_v2.py test/models/test_model_registry_v2.py | sample size: N=2 files | result: pass

Risk / Compatibility

  • Built-in names, aliases, chat precedence, and force_simple remain unchanged.
  • The collector is the only branch authorized to merge this registry stack.

Type of Change

  • Bug fix (non-breaking change)
  • New feature
  • New benchmark/task
  • New model integration
  • Breaking change
  • Documentation update
  • Refactoring (no functional changes)

@Luodian
Luodian changed the base branch from brian/ci/hermetic-eval-contracts to main August 24, 2026 05:48
@Luodian
Luodian changed the base branch from main to brian/ci/hermetic-eval-contracts August 24, 2026 05:49
@Luodian Luodian changed the title refactor(models): (PR1/4) isolate plugin registration failures refactor(models): (PR 1/4) isolate plugin registration failures Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant