Applied mutation testing to improve the quality of the tests and the code for Java implementation. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applied [mutation testing](http://confreaks.tv/videos/mwrc2014-re-thinking-regression-testing) with Ortask Mutator 1.9. Improved the quality of the tests (and the code) by 13% (from a score of 84.6% to 95.3%). - Explicitly made public fields 'public'. - Corrected the comparison of the error value by introducing bounds for it (added a new error precision field). -- Best programming practice: floats/doubles should never be compared like ints. - Made the new error precision part of the public API.
Applied [mutation testing](http://confreaks.tv/videos/mwrc2014-re-thinking-regression-testing) with Ortask Mutator 1.9. Improved the quality of the tests (and the code) by 13% (from a score of 84.6% to 95.3%). - Added needed tests to document behavior with bad and edge-case parameters.
omgm
changed the title
omgm
changed the title
Collaborator
There was a problem hiding this comment.
If these are public, might as well make them final
Member
There was a problem hiding this comment.
@bergundy they were package private before this PR. If the test is running in the same package, I suggest we keep them package-private, and final is just a nice addition.
Collaborator
There was a problem hiding this comment.
@omgm please change the attributes to final protected
Contributor
Author
There was a problem hiding this comment.
Sorry guys, didn't know you were waiting on me. Changes have been done.
For mutation analysis, I create a new test to leave the original one intact. I forgot to clean up the new tests when I committed. This has been fixed.
Made client-accessible fields 'protected final' as agreed.
bergundy
added a commit
that referenced
this pull request
Aug 11, 2015
Applied mutation testing to improve the quality of the tests and the code for Java implementation.
Collaborator
|
@omgm merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied mutation testing with Ortask Mutator 1.9. Improved the quality of the tests (and the code) by 13% (from a score of 84.6% to 95.3%).
-- Best programming practice: floats/doubles should never be compared like ints.