Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/123 핸드북 챕터 1 ~ 2 템플릿 적용 #125

Merged
merged 2 commits into from
Sep 4, 2021

Conversation

josworks27
Copy link
Member

@josworks27 josworks27 commented Sep 4, 2021

Description

GA 핸드북 챕터 1 ~ 2에 작성 규칙에 따른 템플릿을 적용하였습니다.

Help Wanted 👀

핸드북 작성 규칙에 대한 많은 분들의 기여가 필요합니다.
https://www.notion.so/Rule-0ac411634c284a3fbd5b7274f4827cd7

Related Issues

resolve #122

Checklist ✋

  • 모든 변경점들을 확인했으며 적절히 설명했습니다.
  • 빌드가 정상적으로 수행됨을 확인했습니다. (yarn build)

* GA 기본 챕터1 신규 템플릿 적용
* UA-GA4 차이점 신규 템플릿 적용
* relates to EveryAnalytics#122
Copy link
Member

@greatSumini greatSumini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
핸드북 작성 규칙 너무 잘 만들어주셨네요!! CONTRIBUTING.md에 추가해서 관리해봐도 좋을 것 같습니다 ㅎㅎ

@josworks27
Copy link
Member Author

josworks27 commented Sep 4, 2021

@greatSumini 대부분 @NamNamju 님이 만들어주셨는데, 부족한 내용 기여 부탁드립니다 🤣🙌

@josworks27 josworks27 merged commit 6861e44 into EveryAnalytics:main Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

핸드북 챕터 1 ~ 2 템플릿 적용
3 participants