Skip to content

Conversation

@aonkeeper4
Copy link
Contributor

@aonkeeper4 aonkeeper4 commented Dec 17, 2025

This PR adds a useInteract option to EventTrigger to allow activating the cutscene via an interact prompt, rather than via entering the trigger. To complement this, it also adds a deleteFlag option to allow preventing the trigger from loading via a flag. The reasoning behind this is that while doing the "don't load if this flag is set" logic in the cutscene works for activation via entering the trigger, for activation via interact, the interact prompt would still be visible even though the cutscene would not play.
Requires map editor support for 2 new attributes on eventTrigger: useInteract and deleteFlag.

@maddie480-bot maddie480-bot added the review needed This PR needs 2 approvals to be merged (bot-managed) label Dec 17, 2025
@SilverDorian46
Copy link
Contributor

I mean... on one hand, why not patch the InteractTrigger?
(preferably with a new CustomInteract attribute / event, since it uses different strings)

but on the other hand, yeah, the deleteFlag option may be useful.
or... you could maybe add a parameter (or two?) to the CustomEvent attribute, and that will check for whether a flag is set (or unset) before doing the cutscene

@Wartori54 Wartori54 added the should be squashed PR with a messy commit history that should be squash merged label Dec 18, 2025
@aonkeeper4
Copy link
Contributor Author

I feel patching InteractTrigger and using a second attribute would cause unnecessary duplication (I did want to patch it originally to use the same CustomEvent attribute, but that would require backwards-incompatible changes), and the only real difference in behaviour it has is the ability to trigger different cutscenes on sequential interacts. I don't mind taking this approach though if people agree it would be better.

…ing triggering a cutscene multiple times per room load
@aonkeeper4
Copy link
Contributor Author

I noticed InteractTriggers don't prevent themselves from activating multiple times in the same room, so I thought that an onlyOnce option (defaulting to true) would be a good idea to add too.
Also, I forgot to mention this in the PR body but the location of the interact prompt can be customized via the position of the trigger's node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review needed This PR needs 2 approvals to be merged (bot-managed) should be squashed PR with a messy commit history that should be squash merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants