Add workspace to MiniInstaller #1037
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddie480-bot
added
review needed
Wartori54
requested changes
Dec 16, 2025
Member
Wartori54
left a comment
Wartori54
left a comment
There was a problem hiding this comment.
Just some polish needed here and there.
About your fast mode question, I'd be fine with merging without any changes to fast mode, it is meant for advanced users only, so if the installation breaks the user will notice that and be able to fix it.
maddie480-bot
added
changes requested
Contributor
Author
|
Thanks @Wartori54 for the feedback, all comments are addressed in the latest commit. |
Wartori54
requested changes
Dec 18, 2025
Member
Wartori54
left a comment
Wartori54
left a comment
There was a problem hiding this comment.
Other than this LGTM. Would appreciate some testing on other platforms before merging though.
MiniInstaller/DepCalls.cs
Outdated
| try { | ||
| // We're lazy. | ||
| Environment.SetEnvironmentVariable("MONOMOD_DEPDIRS", Globals.PathGame); | ||
| Environment.SetEnvironmentVariable("MONOMOD_DEPDIRS", $"{Globals.PathMiniInstallerWorkspace}:{Globals.PathGame}"); // Prioritize workspace |
Member
There was a problem hiding this comment.
While on Unix systems the path separator is always :, on windows it is not, use Path.PathSeparator instead to ensure it working on all platforms.
MiniInstaller/DepCalls.cs
Outdated
| Logger.LogLine($"Running MonoMod.RuntimeDetour.HookGen for {asm}"); | ||
| // We're lazy. | ||
| Environment.SetEnvironmentVariable("MONOMOD_DEPDIRS", Globals.PathGame); | ||
| Environment.SetEnvironmentVariable("MONOMOD_DEPDIRS", $"{Globals.PathMiniInstallerWorkspace}:{Globals.PathGame}"); // Prioritize workspace |
Contributor
Author
|
The latest commit uses |
Wartori54
approved these changes
Dec 22, 2025
maddie480-bot
added
review needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a workspace folder to the MiniInstaller installation process, so it doesn't overwrite
Celeste.exeearly (for example, during the step applying Everest patches, after coreification).The workspace is used to store the
Celeste.exe/Celeste.dllfiles, until after the step applying Everest patches, reducing the time window during which the process can be interrupted and left in a state which would alloworig/Celeste.exeto be coreified.This is a work in progress, the following still needs to be done:
Fixes #983.
Fixes #984.
As far as I understand, #984 occurs only because of #983.