Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring Postgres datasource builder #341

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

alexeyzimarev
Copy link
Contributor

Fixes #323.

Copy link

Test Results

 54 files  + 36   54 suites  +36   10m 56s ⏱️ + 7m 41s
162 tests +  4  162 ✅ +  4  0 💤 ±0  0 ❌ ±0 
474 runs  +316  474 ✅ +316  0 💤 ±0  0 ❌ ±0 

Results for commit 2e85521. ± Comparison against base commit f3d8029.

This pull request removes 2 and adds 6 tests. Note that renamed tests count towards both.
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-13T12:55:37.0893890+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-13T12:55:37.0893890+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2024-06-13T12:55:37.0893890+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-13T12:55:37.0893890+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-13T12:55:37.0893890+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-13T12:55:37.0893890+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-13T12:55:37.0893890+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-13T12:55:37.0893890+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2024-06-13T12:55:37.0893890+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-13T12:55:37.0893890+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-13T16:24:33.3425077+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-13T16:24:33.3425077+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2024-06-13T16:24:33.3425077+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-13T16:24:33.3425077+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-13T16:24:33.3425077+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-13T16:24:33.3425077+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-13T16:24:33.3425077+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-13T16:24:33.3425077+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2024-06-13T16:24:33.3425077+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-13T16:24:33.3425077+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-13T16:24:34.2825319+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-13T16:24:34.2825319+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2024-06-13T16:24:34.2825319+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-13T16:24:34.2825319+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-13T16:24:34.2825319+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-13T16:24:34.2825319+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-13T16:24:34.2825319+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-13T16:24:34.2825319+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2024-06-13T16:24:34.2825319+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-13T16:24:34.2825319+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-13T16:24:44.1725937+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-13T16:24:44.1725937+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2024-06-13T16:24:44.1725937+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-13T16:24:44.1725937+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-13T16:24:44.1725937+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-13T16:24:44.1725937+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-13T16:24:44.1725937+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-13T16:24:44.1725937+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2024-06-13T16:24:44.1725937+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-13T16:24:44.1725937+00:00 })

@alexeyzimarev alexeyzimarev merged commit 5e03a07 into dev Jun 16, 2024
6 checks passed
@alexeyzimarev alexeyzimarev deleted the configure-ds-builder branch June 16, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable custom configuration of NpgsqlDataSourceBuilder when using AddEventuousPostgres
1 participant