Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Sql groupby and orderby with aliases and projections #3177

Conversation

universalmind303
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the bug Something isn't working label Nov 4, 2024
Copy link

codspeed-hq bot commented Nov 4, 2024

CodSpeed Performance Report

Merging #3177 will not alter performance

Comparing universalmind303:sql-orderby-with-projection-2 (82d5b6a) with main (64e35f8)

Summary

✅ 17 untouched benchmarks

Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's kind of terrible to me that SQL allows this in the first place, but this implementation looks good!

src/daft-sql/src/planner.rs Outdated Show resolved Hide resolved
Co-authored-by: Kev Wang <kev@kevwang.dev>
@universalmind303 universalmind303 enabled auto-merge (squash) November 5, 2024 23:55
@universalmind303 universalmind303 merged commit 8ed174c into Eventual-Inc:main Nov 6, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants