Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] enable decimal between #3154

Merged
merged 1 commit into from
Oct 30, 2024
Merged

[FEAT] enable decimal between #3154

merged 1 commit into from
Oct 30, 2024

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Oct 30, 2024

  • Enables Between for Decimal128

@github-actions github-actions bot added the enhancement New feature or request label Oct 30, 2024
Copy link

codspeed-hq bot commented Oct 30, 2024

CodSpeed Performance Report

Merging #3154 will not alter performance

Comparing sammy/enable-decimal-between (da1fc33) with main (c78fef4)

Summary

✅ 17 untouched benchmarks

@samster25 samster25 enabled auto-merge (squash) October 30, 2024 21:06
@samster25 samster25 merged commit 975c09e into main Oct 30, 2024
42 checks passed
@samster25 samster25 deleted the sammy/enable-decimal-between branch October 30, 2024 21:06
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.73%. Comparing base (c78fef4) to head (da1fc33).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-schema/src/dtype.rs 66.66% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3154      +/-   ##
==========================================
- Coverage   78.73%   78.73%   -0.01%     
==========================================
  Files         621      621              
  Lines       75187    75191       +4     
==========================================
+ Hits        59198    59199       +1     
- Misses      15989    15992       +3     
Files with missing lines Coverage Δ
src/daft-core/src/array/ops/between.rs 86.66% <ø> (ø)
src/daft-core/src/series/ops/between.rs 75.00% <100.00%> (+3.12%) ⬆️
src/daft-schema/src/dtype.rs 83.67% <66.66%> (-0.27%) ⬇️

... and 3 files with indirect coverage changes

sagiahrac pushed a commit to sagiahrac/Daft that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants