Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] (Revert:) Add rust cache to s3 build artifacts action #3147

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Oct 29, 2024

Reverts #3144

The rust cache did not work as intended. We should try sccache instead.

@github-actions github-actions bot added the chore label Oct 29, 2024
@jaychia jaychia changed the title Revert "[CHORE] Add rust cache to s3 build artifacts action" [CHORE] (Revert:) Add rust cache to s3 build artifacts action Oct 29, 2024
@jaychia jaychia enabled auto-merge (squash) October 29, 2024 18:37
Copy link

codspeed-hq bot commented Oct 29, 2024

CodSpeed Performance Report

Merging #3147 will not alter performance

Comparing revert-3144-jay/rust-cache-build-s3 (3280efc) with main (14b2246)

Summary

✅ 17 untouched benchmarks

@jaychia jaychia merged commit e84ed5b into main Oct 29, 2024
42 checks passed
@jaychia jaychia deleted the revert-3144-jay/rust-cache-build-s3 branch October 29, 2024 18:55
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.79%. Comparing base (14b2246) to head (3280efc).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3147   +/-   ##
=======================================
  Coverage   78.79%   78.79%           
=======================================
  Files         621      621           
  Lines       74807    74807           
=======================================
  Hits        58947    58947           
  Misses      15860    15860           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant