Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Enable debug in test profile #3135

Merged

Conversation

advancedxy
Copy link
Contributor

I'm using RustRover to code and debug Rust related code and I noticed the debug run in RustRover doesn't work out of box: there's no variable showing when breakpoint is hit.

It turns out that the RustRover IDE will launch debug process with test profile, which is inherited from dev1 profile. I am not sure why the dev2 profile in this project is configured without debug enabled. I add the test profile with debug enabled in this PR.

Footnotes

  1. https://doc.rust-lang.org/cargo/reference/profiles.html#test

  2. https://github.com/Eventual-Inc/Daft/blob/main/Cargo.toml#L86

@github-actions github-actions bot added the chore label Oct 28, 2024
Copy link

codspeed-hq bot commented Oct 28, 2024

CodSpeed Performance Report

Merging #3135 will not alter performance

Comparing advancedxy:enable_debug_in_test_profile (7f72805) with main (5228930)

Summary

✅ 17 untouched benchmarks

@samster25 samster25 merged commit f966e02 into Eventual-Inc:main Oct 31, 2024
38 checks passed
sagiahrac pushed a commit to sagiahrac/Daft that referenced this pull request Nov 4, 2024
I'm using RustRover to code and debug Rust related code and I noticed
the debug run in RustRover doesn't work out of box: there's no variable
showing when breakpoint is hit.

It turns out that the RustRover IDE will launch debug process with test
profile, which is inherited from dev[^1] profile. I am not sure why the
dev[^2] profile in this project is configured without debug enabled. I
add the test profile with debug enabled in this PR.

[^1]: https://doc.rust-lang.org/cargo/reference/profiles.html#test
[^2]: https://github.com/Eventual-Inc/Daft/blob/main/Cargo.toml#L86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants