Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Streaming physical writes for native executor #2992
[FEAT] Streaming physical writes for native executor #2992
Changes from 14 commits
4d5af1a
823e889
3854cd2
56c8416
b662ad9
4db34f0
4f12640
9ed8e84
16f3f7d
11d9244
685416b
85ab44c
0ce9dcc
03dcfcb
bc9c7fa
92c4d03
072ae6e
b67499e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Check warning on line 3 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L1-L3
Check warning on line 7 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L5-L7
Check warning on line 14 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L12-L14
Check warning on line 18 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L18
Check warning on line 22 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L21-L22
Check warning on line 35 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L32-L35
Check warning on line 40 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L37-L40
Check warning on line 44 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L44
Check warning on line 46 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L46
Check warning on line 50 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L48-L50
Check warning on line 53 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L52-L53
Check warning on line 56 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L55-L56
Check warning on line 62 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L62
Check warning on line 65 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L64-L65
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we name this something like
start_next_file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mirroring the above comment, the python file writers should not write after close
Check warning on line 71 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L71
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also have a
finalize
method rather than overloadingclose
to start a next file and closing the last fileThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was actually intending for these Python writers to be non rotating. i.e. no writing after closing. They should be given a unique file_idx for the file_name generation upon construction, and unique set of partition_values.
I will add assertions and some comments to document this behaviour
Check warning on line 75 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L74-L75
Check warning on line 83 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L83
Check warning on line 93 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L92-L93
Check warning on line 104 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L101-L104
Check warning on line 108 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L106-L108
Check warning on line 114 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L110-L114
Check warning on line 118 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L117-L118
Check warning on line 125 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L125
Check warning on line 134 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L133-L134
Check warning on line 142 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L139-L142
Check warning on line 146 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L144-L146
Check warning on line 152 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L148-L152