Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Concat for native executor #2976

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Conversation

colin-ho
Copy link
Contributor

Depends on #2860

@github-actions github-actions bot added the enhancement New feature or request label Sep 30, 2024
Copy link

codspeed-hq bot commented Sep 30, 2024

CodSpeed Performance Report

Merging #2976 will not alter performance

Comparing colin/swordfish-concat (a2ca316) with main (b2dabf6)

Summary

✅ 17 untouched benchmarks

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 98.20467% with 10 lines in your changes missing coverage. Please review.

Project coverage is 78.89%. Comparing base (412dfbc) to head (a2ca316).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...local-execution/src/sinks/outer_hash_join_probe.rs 98.50% 4 Missing ⚠️
...tion/src/intermediate_ops/inner_hash_join_probe.rs 97.16% 3 Missing ⚠️
src/daft-local-execution/src/sinks/concat.rs 84.21% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2976      +/-   ##
==========================================
+ Coverage   78.39%   78.89%   +0.50%     
==========================================
  Files         596      600       +4     
  Lines       69687    70382     +695     
==========================================
+ Hits        54629    55531     +902     
+ Misses      15058    14851     -207     
Flag Coverage Δ
78.89% <98.20%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../src/intermediate_ops/anti_semi_hash_join_probe.rs 96.61% <100.00%> (+0.24%) ⬆️
src/daft-local-execution/src/lib.rs 90.47% <100.00%> (+0.73%) ⬆️
src/daft-local-execution/src/pipeline.rs 93.38% <100.00%> (+2.06%) ⬆️
src/daft-local-execution/src/runtime_stats.rs 55.67% <100.00%> (+0.46%) ⬆️
.../daft-local-execution/src/sinks/hash_join_build.rs 95.00% <100.00%> (-0.24%) ⬇️
src/daft-local-execution/src/sinks/limit.rs 100.00% <100.00%> (ø)
...c/daft-local-execution/src/sinks/streaming_sink.rs 81.45% <100.00%> (+13.98%) ⬆️
src/daft-table/src/lib.rs 90.55% <ø> (ø)
src/daft-table/src/probeable/mod.rs 100.00% <100.00%> (ø)
...tion/src/intermediate_ops/inner_hash_join_probe.rs 97.16% <97.16%> (ø)
... and 2 more

... and 58 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant