Remove unneeded isPlainObject function #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's the function caller's responsibility to pass the expected argument type. If they pass something "truthy" that is not an Object object, then the behavior of the function is undefined. We shouldn't work around such mistakes by the caller (i.e. what did they mean to pass for the argument?) and why should we care if the Object object is of the "plain" variety. This pull request is just a half step in the right direction. A better solution would be to throw an exception on receiving incorrect arguments.
|
See #69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's the function caller's responsibility to pass the expected argument type. If they pass something "truthy" that is not an Object object, then the behavior of the function is undefined. We shouldn't work around such mistakes by the caller. What did they mean to pass for the argument? And why should we care if the Object object is of the "plain" variety?
This pull request is just a half step in the right direction. A better solution would be to throw an exception on receiving incorrect arguments.