Explicitly raise an error when server returns http 403 and dont continue #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if the server returned a 403, eventsource would begin a retry loop to connect to the server over and over. This loop will start before a client can attach to the 'error' event because eventsource connects right away in the constructor. This prevents client code from closing the eventsource connection. This commit addresses this issue and fails fast instead of allowing eventsource to enter a retry loop when a server returns a 403.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if the server returned a 403, eventsource would begin a retry
loop to connect to the server over and over. This loop will start before
a client can attach to the 'error' event because eventsource connects
right away in the constructor. This prevents client code from closing
the eventsource connection. This commit addresses this issue and fails
fast instead of allowing eventsource to enter a retry loop when a server
returns a 403.