Improve performance for large messages across many chunks #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentmwillis
force-pushed
the
large-message-perf
branch
from
64eefa3 to
53d5827
Compare
aslakhellesoy
requested changes
Oct 10, 2019
trentmwillis
force-pushed
the
large-message-perf
branch
from
53d5827 to
3cddbc2
Compare
sdemontfort
pushed a commit
to sdemontfort/js-eventsource
that referenced
this pull request
May 7, 2020
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently ran into an issue with large payloads (megabytes in size) that arrived over many chunks. As the size increased, the time to process them seemed to increase exponentially. After investigating a bit, realized that each time a new chunk arrives, any data in the buffer from before gets re-parsed. Thus, for very large messages you might wind up re-parsing the early data many times.
This change adds a couple variables to track data that has already been processed to skip evaluating it multiple times.