Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Event object on open and error event #30

Closed
flowersinthesand opened this issue Nov 14, 2013 · 1 comment
Closed

Provide Event object on open and error event #30

flowersinthesand opened this issue Nov 14, 2013 · 1 comment

Comments

@flowersinthesand
Copy link
Contributor

To be the spec compatible, implementation should provide Event object on open and error event. Now it doesn't pass anything so that chaining is broken in my case.
https://github.com/flowersinthesand/portal/blob/9e5b28317a7fcbd5e527480842310b2425ca9c25/portal.js#L1494-L1510

See
http://www.w3.org/TR/DOM-Level-3-Events/#interface-Event
http://www.w3.org/TR/eventsource/#the-eventsource-interface
@aslakhellesoy
Copy link
Contributor

Feel free to send a pull request with a fix.

aslakhellesoy added a commit that referenced this issue Nov 21, 2013
@aslakhellesoy
MessageEvent is always of type message. Attibution, closes #30, #31.
be11701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aslakhellesoy @flowersinthesand