Fixed issues which inhibited subclassing. #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageRow
andImageCell
cannot be directly sub-classed, due to it's final modifiers.Therefore, sub-classing needs to be done like this:
(In this case, it is, because I need a styled cell using a XIB.)
A non-public
ImageRowProtocol
effectively prevents that.Additionally,
ImagePickerController
castsrow
toImageRow
which we can't fulfill when overriding,Config options are therefore ignored.
To resolve this, I introduced an
ImagePickerProtocol
.Would be great, if you could merge this, so I don't have to rely on my fork.
Thanks a lot!
Benjamin