Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TypeScript types #41

Merged
merged 1 commit into from
May 2, 2021
Merged

Update TypeScript types #41

merged 1 commit into from
May 2, 2021

Conversation

gluons
Copy link
Contributor

@gluons gluons commented May 2, 2021

Data

  • Assign eventContainerStyle type to style type of View.
  • Assign position type to 'left' | 'right' for better type hinting.

TimelineProps

@gluons
Copy link
Contributor Author

gluons commented May 2, 2021

More info

onEventPress type seems incorrect.
onEventPress actually pass a data item (aka. rowData). Not Event.

It should be fixed?

@Eugnis Eugnis merged commit fa8192b into Eugnis:master May 2, 2021
@Eugnis
Copy link
Owner

Eugnis commented May 2, 2021

Thank you!

@gluons gluons deleted the improve-types branch May 2, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants