Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash on Windows 7 #6027

Merged
merged 1 commit into from
Mar 26, 2022
Merged

fix crash on Windows 7 #6027

merged 1 commit into from
Mar 26, 2022

Conversation

ysc3839
Copy link
Contributor

@ysc3839 ysc3839 commented Mar 26, 2022

After debugging I found the crash on win7 is caused by DwmEnableBlurBehindWindow in window.ts.
window.ts pass this.window to windows-blurbehind, then windows-blurbehind pass this object to node::Buffer::Data:
https://github.com/Eugeny/windows-blurbehind/blob/30a3dd4f357493d796c1e4770f478bdf6840d4af/src/blurbehind.cc#L7
node::Buffer::Data found it's not a ArrayBufferView and crash:
https://github.com/nodejs/node/blob/v16.13.0/src/node_buffer.cc#L246

Tabby 1.0.167 uses electron 13.5.1, I don't know why it works. According to electron docs, here should use win.getNativeWindowHandle() to get Buffer of window handle.

Fixes #5339, #5465, #5528, #5794

@Eugeny
Copy link
Owner

Eugeny commented Mar 26, 2022

Great find - thanks for fixing! 👍

@allcontributors please add @ysc3839 for code

@Eugeny Eugeny merged commit 018355c into Eugeny:master Mar 26, 2022
@allcontributors
Copy link
Contributor

@Eugeny

I've put up a pull request to add @ysc3839! 🎉

@ysc3839 ysc3839 deleted the fix-win7-crash branch March 26, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alpha 169 crashes on startup on Windows 7
2 participants