Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows signing #10100

Merged
merged 30 commits into from
Dec 24, 2024
+457 −263
Merged

Windows signing #10100

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
e1e6e1c
Update entitlements.plist
Eugeny Dec 15, 2024
5889f69
.
Eugeny Dec 18, 2024
23d2aa4
Update build.yml
Eugeny Dec 18, 2024
a420aaa
Update build.yml
Eugeny Dec 18, 2024
54207d3
Update build.yml
Eugeny Dec 18, 2024
e3596b0
Update build.yml
Eugeny Dec 18, 2024
36b66bc
Update build.yml
Eugeny Dec 18, 2024
2b2ce4e
.
Eugeny Dec 18, 2024
984ab61
.
Eugeny Dec 18, 2024
d8a9240
Update build-windows.mjs
Eugeny Dec 18, 2024
0a1e4b1
Update build-windows.mjs
Eugeny Dec 19, 2024
0377974
.
Eugeny Dec 19, 2024
10e5914
Update build.yml
Eugeny Dec 19, 2024
21757b7
.
Eugeny Dec 19, 2024
c965994
Update build.yml
Eugeny Dec 19, 2024
b66ef4d
Update build.yml
Eugeny Dec 19, 2024
0b9691d
Update build.yml
Eugeny Dec 19, 2024
d518d6e
Update build.yml
Eugeny Dec 19, 2024
58b5c21
gyp bump
Eugeny Dec 19, 2024
c6683a3
Merge branch 'master' into signingtest
Eugeny Dec 24, 2024
e56403d
fail when sign fails
Eugeny Dec 24, 2024
4691741
Update build.yml
Eugeny Dec 24, 2024
a808e77
Merge branch 'signingtest' of github.com:Eugeny/tabby into signingtest
Eugeny Dec 24, 2024
0b37332
Update build-windows.mjs
Eugeny Dec 24, 2024
2221e23
Update build-windows.mjs
Eugeny Dec 24, 2024
6351ab4
.
Eugeny Dec 24, 2024
69e6d22
Update build.yml
Eugeny Dec 24, 2024
cb7ca13
Update build.yml
Eugeny Dec 24, 2024
2c31eec
Update build.yml
Eugeny Dec 24, 2024
7d42a02
Update build.yml
Eugeny Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update build-windows.mjs
  • Loading branch information
@Eugeny
Eugeny committed Dec 24, 2024
commit 0b37332db556ec0e4d77eed8448cb8cfae291cfc
5 changes: 4 additions & 1 deletion scripts/build-windows.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ const keypair = process.env.SM_KEYPAIR_ALIAS

process.env.ARCH = process.env.ARCH || process.arch

console.log('Signing enabled:', !!keypair)

builder({
dir: true,
win: ['nsis', 'zip'],
Expand All @@ -24,12 +26,13 @@ builder({
channel: `latest-${process.env.ARCH}`,
},
] : undefined,
forceCodeSigning: !!keypair,
win: {
certificateSha1: process.env.SM_CODE_SIGNING_CERT_SHA1_HASH,
publisherName: process.env.SM_PUBLISHER_NAME,
signingHashAlgorithms: ['sha256'],
forceCodeSigning: !!keypair,
sign: keypair ? async function (configuration) {
console.log('Signing', configuration)
if (configuration.path) {
try {
execSync(
Expand Down
Loading