Genuary: include linked media from Genuary threads #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to fill out jobs Co-Authored-By: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
Co-Authored-By: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
✅ Deploy Preview for acmcsuf ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
- cleaned up some commented out logs - linting - job logic Co-Authored-By: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
EthanThatOneKid
changed the title
EthanThatOneKid
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Congratulations on your amazing PR, @jiink!
Excited to finally see .github/workflows/update_genuary.yaml trigger in prod!
EthanThatOneKid
requested changes
Mar 29, 2023
Co-authored-by: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
EthanThatOneKid
approved these changes
Mar 29, 2023
|
Keep an eye out for https://acmcsuf.com/code/actions/workflows/update_genuary.yaml on March 29th, 2023! 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve #769, the logic to get media from a pinned message needs to be changed.