-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Officer data: Update officers.json and tiers.json #620
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thank you so much for updating the tiers. This is easy to follow and very clear to understand. There were a couple things that I would like to be clarified:
There were two members who had previously worked as a "workshop manager". Should we include that into the tier list? Perhaps as "Workshop Manager": { "id": 23, "index": 1250" }
so we can replace "ICC Representative": { "id": 24", "index": 1300 }
. This is simply a suggestion and is not required!
For consistency, I suggest we update the "nodebuds officer" title to "Nodebuds Officer" to reflect the other titles such as "Dev Officer" or "Algo Officer"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
In
officers.json
, the order that the officers should be listed is determined by a separateTier
(stored intiers.json
) which is referenced by ID.The
officers.json
has some rules that should always be guaranteed:officers.json
.Example updated
Tier
s:acmcsuf.com/src/lib/public/board/data/tiers.json
Lines 3 to 4 in 414c3f7
Example updated
Officer
(using IDs of example tiers above):acmcsuf.com/src/lib/public/board/data/officers.json
Lines 63 to 68 in 414c3f7