Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officer data: Update officers.json and tiers.json #620

Merged
merged 5 commits into from
Oct 23, 2022
Merged

Conversation

EthanThatOneKid
Copy link
Owner

@EthanThatOneKid EthanThatOneKid commented Oct 16, 2022

In officers.json, the order that the officers should be listed is determined by a separate Tier (stored in tiers.json) which is referenced by ID.

The officers.json has some rules that should always be guaranteed:

  • Officer position tiers should be synced with the appropriate tier ID.
  • Officers are listed in alphabetical order in officers.json.

Example updated Tiers:

"Vice President": { "id": 1, "index": 150 },
"Webmaster": { "id": 2, "index": 200 },

Example updated Officer (using IDs of example tiers above):

"positions": {
"S21": { "title": "Webmaster", "tier": 2 },
"F21": { "title": "Webmaster", "tier": 2 },
"S22": { "title": "Webmaster", "tier": 2 },
"F22": { "title": "Vice President/Webmaster", "tier": 1 }
}

@vercel
Copy link

vercel bot commented Oct 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
acm-csuf-site ✅ Ready (Inspect) Visit Preview Oct 23, 2022 at 5:46AM (UTC)

@EthanThatOneKid EthanThatOneKid linked an issue Oct 16, 2022 that may be closed by this pull request
@EthanThatOneKid EthanThatOneKid changed the title Officer data: Update officer.json and tiers.json Officer data: Update officers.json and tiers.json Oct 16, 2022
Copy link
Collaborator

@karnikaavelumani karnikaavelumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you so much for updating the tiers. This is easy to follow and very clear to understand. There were a couple things that I would like to be clarified:

There were two members who had previously worked as a "workshop manager". Should we include that into the tier list? Perhaps as "Workshop Manager": { "id": 23, "index": 1250" } so we can replace "ICC Representative": { "id": 24", "index": 1300 }. This is simply a suggestion and is not required!

For consistency, I suggest we update the "nodebuds officer" title to "Nodebuds Officer" to reflect the other titles such as "Dev Officer" or "Algo Officer"

@vercel vercel bot temporarily deployed to Preview October 17, 2022 01:53 Inactive
Copy link
Collaborator

@karnikaavelumani karnikaavelumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@EthanThatOneKid EthanThatOneKid marked this pull request as ready for review October 17, 2022 17:19
@EthanThatOneKid EthanThatOneKid requested review from diamondburned and removed request for diamondburned October 17, 2022 17:19
@EthanThatOneKid EthanThatOneKid enabled auto-merge (squash) October 23, 2022 05:45
@vercel vercel bot temporarily deployed to Preview October 23, 2022 05:46 Inactive
@EthanThatOneKid EthanThatOneKid merged commit 6f43b29 into main Oct 23, 2022
@jaasonw jaasonw deleted the fix/618 branch December 27, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Officer data: tiers.json does not affect anything
3 participants