Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officer List: Integrated tier-based ordering #326

Merged
merged 5 commits into from
Mar 6, 2022
Merged

Conversation

EthanThatOneKid
Copy link
Owner

Notes

  • Added tier options to .github/ISSUE_TEMPLATE/officer_update_request.yaml
  • Added GitHub username input to .github/ISSUE_TEMPLATE/officer_update_request.yaml
  • Updated scripts/update-officer.js to account for new input fields
  • Officers are sorted by tier before rendering the officer profile list
  • Tiers are not visible by default, but can be toggled by a developer via <OfficerProfile dev={true} />

Resolves #152.

@EthanThatOneKid EthanThatOneKid added the enhancement New feature or request label Mar 6, 2022
@vercel
Copy link

vercel bot commented Mar 6, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/DhFfoZERJa8bz6VSZjEf2w3SZuqQ
✅ Preview: https://acm-csuf-site-git-fix-152-ethanthatonekid.vercel.app

@EthanThatOneKid EthanThatOneKid requested a review from a user March 6, 2022 21:25
@EthanThatOneKid EthanThatOneKid changed the title Integrated tier-based ordering for officers list Officer List: Integrated tier-based ordering Mar 6, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pog champion

@vercel vercel bot temporarily deployed to Preview March 6, 2022 21:30 Inactive
@EthanThatOneKid EthanThatOneKid merged commit 286457b into main Mar 6, 2022
@EthanThatOneKid EthanThatOneKid deleted the fix/152 branch March 6, 2022 21:31
@jaasonw
Copy link
Contributor

jaasonw commented Mar 6, 2022

tiers:
s tier: @jaasonw
d tier: @mikeploythai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Position counter for OfficerProfile
2 participants