Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer tool for generating ACM officer file 🤖 #54

Closed
EthanThatOneKid opened this issue Apr 10, 2021 · 1 comment · Fixed by #186
Closed

Developer tool for generating ACM officer file 🤖 #54

EthanThatOneKid opened this issue Apr 10, 2021 · 1 comment · Fixed by #186
Assignees
Labels
developer experience Enhancement geared towards the devs devops Some operation must be executed enhancement New feature or request

Comments

@EthanThatOneKid
Copy link
Owner

The current list of officers used in this project is hard-coded in the lib directory. Preferably, this file should be generated by a script of some sort for the sake of a better developer experience.

@EthanThatOneKid EthanThatOneKid added the developer experience Enhancement geared towards the devs label Aug 26, 2021
@EthanThatOneKid EthanThatOneKid added the devops Some operation must be executed label Oct 20, 2021
@EthanThatOneKid
Copy link
Owner Author

EthanThatOneKid commented Oct 20, 2021

We could create a workflow that updates the officer data (via automated PR) whenever a specific kind of GitHub issue is created by a contributor. This issue would be created using an issue template. The issue template would ask if we want to update/add officer data for one or more officers or delete one or more officers. The automated PR will succeed only if the issue opener is an authorized contributor.

I proved that it is possible to store the data in a JSON file (officers.json) in #154, so all the automated PR has to do is edit that one file.

The script used to create the necessary changes can just be written in Node.js to prevent any unneeded context-switching.

The neat thing about automating a PR is that Vercel should automatically build and deploy a preview to reflect the changes as well.

Note: this solution might be over-engineered, but feels like a fun introductory devops project nonetheless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience Enhancement geared towards the devs devops Some operation must be executed enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants