Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup #83

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Fix setup #83

merged 2 commits into from
Feb 7, 2022

Conversation

feld
Copy link
Contributor

@feld feld commented Jan 31, 2022

Was not able to build/deploy without these changes.

@piotr-rudnik
Copy link

Hey, setup should be fixed now, there were problems with ethtx (library) python version, so there is no need modify pipenv, but we would be happy to pull those changes related to mongo connection string. Could you delete or revert this pin eth-rlp to 0.2.1 commit?

@kchojn
Copy link
Collaborator

kchojn commented Feb 1, 2022

Hey @feld, thanks for the pr. As Piotrek said, please revert changes with Pipfile. We have removed this error in the engine EthTx. It was related to web3 and pipenv bug (ethereum/web3.py#2314).

After that, we will be happy to merge your changes!

Regards

@kchojn kchojn changed the base branch from master to dev February 1, 2022 17:26
@feld
Copy link
Contributor Author

feld commented Feb 1, 2022

@kchojn done

@kchojn kchojn deleted the branch EthTx:dev February 7, 2022 11:47
@kchojn kchojn closed this Feb 7, 2022
@kchojn kchojn reopened this Feb 7, 2022
@kchojn kchojn merged commit 999afe9 into EthTx:dev Feb 7, 2022
kchojn added a commit that referenced this pull request Feb 7, 2022
* Bump python to 3.9 and set static ethtx version (#87)
* update deps
* get eth_price, update deps
* cache price
* Fix setup (#83)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants