Skip to content

GH-81 Add support for #onlinePlayers with specific permissions #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vLuckyyy merged 2 commits into from
Jul 13, 2025
Merged

GH-81 Add support for #onlinePlayers with specific permissions #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8fd998
Add support for #onlinePlayers with specific permissions
vLuckyyy Jul 13, 2025
1e21de0
Update multification-core/src/com/eternalcode/multification/notice/No…
vLuckyyy Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions multification-bukkit/src/com/eternalcode/multification/bukkit/BukkitViewerProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,17 @@ public Collection<CommandSender> onlinePlayers() {
return Collections.unmodifiableCollection(Bukkit.getOnlinePlayers());
}

@Override
public Collection<CommandSender> onlinePlayers(String permission) {
Collection<CommandSender> playersWithPermission = new ArrayList<>();
for (CommandSender player : Bukkit.getOnlinePlayers()) {
if (player.hasPermission(permission)) {
playersWithPermission.add(player);
}
}
return Collections.unmodifiableCollection(playersWithPermission);
}

@Override
public Collection<CommandSender> all() {
Collection<CommandSender> viewers = new ArrayList<>(this.onlinePlayers());
Expand Down
3 changes: 3 additions & 0 deletions multification-core/src/com/eternalcode/multification/notice/NoticeBroadcast.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ public interface NoticeBroadcast<VIEWER, TRANSLATION, B extends NoticeBroadcast<
@CheckReturnValue
B onlinePlayers();

@CheckReturnValue
B onlinePlayers(String permission);

@CheckReturnValue
B notice(Notice notification);

Expand Down
7 changes: 7 additions & 0 deletions multification-core/src/com/eternalcode/multification/notice/NoticeBroadcastImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,13 @@ public B onlinePlayers() {
return this.getThis();
}

@Override
@CheckReturnValue
public B onlinePlayers(String permission) {
this.viewers.addAll(this.viewerProvider.onlinePlayers(permission));
return this.getThis();
}

@Override
@CheckReturnValue
public B noticeChat(TextMessageProvider<TRANSLATION> extractor) {
Expand Down
2 changes: 2 additions & 0 deletions multification-core/src/com/eternalcode/multification/viewer/ViewerProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ public interface ViewerProvider<VIEWER> {

Collection<VIEWER> onlinePlayers();

Collection<VIEWER> onlinePlayers(String permission);

Collection<VIEWER> all();

}
12 changes: 12 additions & 0 deletions multification-core/test/com/eternalcode/multification/MultificationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,18 @@ public Collection<Viewer> onlinePlayers() {
return ONLINE;
}

@Override
public Collection<Viewer> onlinePlayers(String permission) {
List<Viewer> playersWithPermission = new ArrayList<>();
for (Viewer viewer : ONLINE) {
// Simulating permission check
if (viewer.uuid.equals(ROLLCZI_UUID) || viewer.uuid.equals(LUCKI_UUID)) {
playersWithPermission.add(viewer);
}
}
return playersWithPermission;
}

@Override
public Collection<Viewer> all() {
List<Viewer> list = new ArrayList<>();
Expand Down