GH-58 Add basic Parcel locker business logic #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…til, fix ParcelLockerPlaceController
Jakubk15
added
🆕 feature
Co-authored-by: DMK <81445555+imDMK@users.noreply.github.com>
…ageGUI.java Co-authored-by: DMK <81445555+imDMK@users.noreply.github.com>
…java Co-authored-by: DMK <81445555+imDMK@users.noreply.github.com>
….java Co-authored-by: DMK <81445555+imDMK@users.noreply.github.com>
|
@imDMK I changed the structure, as you requested, and applied your fixes. Let me know if there are any codestyle issues, as the Gradle Checkstyle plugin hasn't detected anything now. |
imDMK
requested changes
Oct 8, 2023
src/main/java/com/eternalcode/parcellockers/parcel/gui/ParcelListGUI.java
Outdated
Show resolved
Hide resolved
src/main/java/com/eternalcode/parcellockers/parcel/gui/ParcelListGUI.java
Outdated
Show resolved
Hide resolved
src/main/java/com/eternalcode/parcellockers/parcel/gui/ParcelListGUI.java
Outdated
Show resolved
Hide resolved
vLuckyyy
reviewed
Oct 12, 2023
Comment on lines
+160
to
+176
| private boolean setupEconomy() { | ||
| if (this.getServer().getPluginManager().getPlugin("Vault") == null) { | ||
| return false; | ||
| } | ||
|
|
||
| RegisteredServiceProvider<Economy> rsp = this.getServer().getServicesManager().getRegistration(Economy.class); | ||
| if (rsp == null) { | ||
| return false; | ||
| } | ||
|
|
||
| this.economy = rsp.getProvider(); | ||
| return true; | ||
| } | ||
|
|
||
| public Economy getEconomy() { | ||
| return this.economy; | ||
| } |
There was a problem hiding this comment.
I don't like this method in main class.
There was a problem hiding this comment.
I'm sorry to hear that, where else can I move this method to?
…istGUI.java Co-authored-by: DMK <81445555+imDMK@users.noreply.github.com>
imDMK
requested changes
Oct 12, 2023
src/main/java/com/eternalcode/parcellockers/parcel/gui/ParcelListGUI.java
Outdated
Show resolved
Hide resolved
…istGUI.java Co-authored-by: DMK <81445555+imDMK@users.noreply.github.com>
# Conflicts: # src/main/java/com/eternalcode/parcellockers/parcel/gui/ParcelListGUI.java
imDMK
requested changes
Oct 14, 2023
src/main/java/com/eternalcode/parcellockers/locker/database/LockerDatabaseService.java
Outdated
Show resolved
Hide resolved
…ckerDatabaseService.java Co-authored-by: DMK <81445555+imDMK@users.noreply.github.com>
imDMK
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-[ ] Parcel receiving- [ ] Parcel statuses IN PROGRESS- [ ] Parcel redeem time update- [ ] Parcel locker deletion by administrator (further logic, what will happen to parcels)Closes #72