Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-100 Implement EternalCodeCommons #107

Merged
merged 6 commits into from
Oct 1, 2024
Merged

GH-100 Implement EternalCodeCommons #107

merged 6 commits into from
Oct 1, 2024

Conversation

Jakubk15
Copy link
Member

No description provided.

@Jakubk15 Jakubk15 requested a review from a team as a code owner September 29, 2024 13:13
@Jakubk15 Jakubk15 changed the title Implement commons GH-100 Implement EternalCodeCommons Sep 29, 2024
@Jakubk15 Jakubk15 added the ⚙️ architecture Applies to architecture label Sep 29, 2024
Rollczi
Rollczi previously approved these changes Sep 29, 2024
@P1otrulla P1otrulla self-requested a review September 29, 2024 14:05
@vLuckyyy vLuckyyy added 💾 code-only This is just a code problem, it doesn't affect the production server and removed ⚙️ architecture Applies to architecture labels Sep 29, 2024
P1otrulla
P1otrulla previously approved these changes Sep 29, 2024
Copy link
Member

@vLuckyyy vLuckyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have ItemUtil and Duration formatter in eternalcode-commons

.github/CODEOWNERS Outdated Show resolved Hide resolved
build.gradle.kts Show resolved Hide resolved
igoyek
igoyek previously approved these changes Sep 30, 2024
@Jakubk15 Jakubk15 dismissed stale reviews from igoyek and P1otrulla via 5630a07 September 30, 2024 18:23
…ementation/ConfigItem.java

Co-authored-by: Martin Sulikowski <vLuckyyy.biznes@gmail.com>
@Jakubk15
Copy link
Member Author

Jakubk15 commented Oct 1, 2024

We also have ItemUtil and Duration formatter in eternalcode-commons

Sadly the ItemUtil has a different behavior than the one I intend to use, so I will stick to mine for the time being. Currently there is no need for implementing the DurationParser, but thanks 😅

@Jakubk15 Jakubk15 merged commit 750e4a0 into master Oct 1, 2024
1 check passed
@Jakubk15 Jakubk15 deleted the implement-commons branch October 1, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💾 code-only This is just a code problem, it doesn't affect the production server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants