GH-1164 Use quicker map return strategy #1164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakubk15
added
the
💾 code-only
This reverts commit 0080777.
Jakubk15
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces two main changes. First, it optimizes command map retrieval in PowertoolCommandArgument by using Collections.unmodifiableMap instead of creating a new map, which is more efficient. Second, it refactors the dependency relocation caching logic in RelocationCacheResolver to use a single global cache file instead of per-dependency caches. This simplifies the implementation. While the changes are generally good, I've pointed out a couple of areas in the exception handling that could be improved for better robustness.
Jakubk15
requested review from
Rollczi,
mydelkonivea,
igoyek,
P1otrulla,
CitralFlo,
VerniQ and
imDMK
imDMK
approved these changes
Sep 17, 2025
igoyek
approved these changes
Sep 18, 2025
P1otrulla
approved these changes
Sep 18, 2025
CitralFlo
approved these changes
Sep 19, 2025
vLuckyyy
approved these changes
Sep 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.