fix http(s) socks5 nyaa search #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd trailing whitespace
fix: 使用反代时 RSS 图标路径错误
fix: 🐛 通知的内容包含无意义的前导和尾随空格
chore: fix typo in experimental docs
fix http https
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
EstrellaXD
reviewed
Oct 8, 2023
| @@ -21,8 +21,11 @@ | |||
|
|
|||
| class SearchTorrent(RequestContent, RSSAnalyser): | |||
| def search_torrents(self, rss_item: RSSItem) -> list[Torrent]: | |||
| torrents = self.get_torrents(rss_item.url) | |||
100gle
reviewed
Oct 8, 2023
Comment on lines
5
to
14
| if not len(soup.findall("./channel/item/enclosure")): | ||
| for item in soup.findall("./channel/item"): | ||
| torrent_titles.append(item.find("title").text) | ||
| torrent_urls.append(item.find("link").text) | ||
| torrent_homepage.append(item.find("guid").text) | ||
| else: | ||
| for item in soup.findall("./channel/item"): | ||
| torrent_titles.append(item.find("title").text) | ||
| torrent_urls.append(item.find("enclosure").attrib["url"]) | ||
| torrent_homepage.append(item.find("link").text) |
There was a problem hiding this comment.
这段代码说实话看着有点冗余，其实在循环的时候是不是只需要对可能会变动的 torrent_urls
和 torrent_homepage 做条件判断就可以了？
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.修复http(s) 带密码验证连接
2.修复socks5不能搜索
3.修复nyaa不能搜索