Skip to content

Commit

Permalink
Input: synaptics_rmi4 - use devm_device_add_group() for attributes in…
Browse files Browse the repository at this point in the history
… F01

Now that we have proper managed API to create device attributes, let's
start using it instead of the manual unwinding.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
dtor authored and gregkh committed Jul 22, 2017
1 parent 3184125 commit 36a44af
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions drivers/input/rmi4/rmi_f01.c
Original file line number Diff line number Diff line change
Expand Up @@ -570,18 +570,14 @@ static int rmi_f01_probe(struct rmi_function *fn)

dev_set_drvdata(&fn->dev, f01);

error = sysfs_create_group(&fn->rmi_dev->dev.kobj, &rmi_f01_attr_group);
error = devm_device_add_group(&fn->rmi_dev->dev, &rmi_f01_attr_group);
if (error)
dev_warn(&fn->dev, "Failed to create sysfs group: %d\n", error);
dev_warn(&fn->dev,
"Failed to create attribute group: %d\n", error);

return 0;
}

static void rmi_f01_remove(struct rmi_function *fn)
{
sysfs_remove_group(&fn->rmi_dev->dev.kobj, &rmi_f01_attr_group);
}

static int rmi_f01_config(struct rmi_function *fn)
{
struct f01_data *f01 = dev_get_drvdata(&fn->dev);
Expand Down Expand Up @@ -721,7 +717,6 @@ struct rmi_function_handler rmi_f01_handler = {
},
.func = 0x01,
.probe = rmi_f01_probe,
.remove = rmi_f01_remove,
.config = rmi_f01_config,
.attention = rmi_f01_attention,
.suspend = rmi_f01_suspend,
Expand Down

0 comments on commit 36a44af

Please sign in to comment.