-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add discord roles blacklist and aliases for chat format #5157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both these features are fine, just a few things;
-
discord-roles-selection
should be made into a blacklist rather than a whitelist, be renamed todiscord-role-blacklist
, and the config should have the examples commented out (like howworld-aliases
are in the main essentials config). -
discord-roles-aliases
should support both discord role names and ids and have their examples commented out as well.
I feel like it being a whitelist is still desired in many cases, perhaps an option to turn the whitelist into a blacklist? This is how DiscordSRV does it too. Will add it to support IDs and comment it out in the config tomorrow |
I think a majority of users will only have a couple of roles they don't want used as top role, such as a default role, rather than a bunch of unwanted top roles |
Maybe a blacklist by default (renaming it to blacklist too) with an option for it to be a whitelist? |
I think that would become confusing, do you have an example of a common use case for a whitelist would be better over a blacklist? |
We have staff ranks inside Minecraft which are roles present in Discord, but the Discord has more roles than that. When messages go to the Minecraft server, we only care about those staff roles going to Minecraft. Having a whitelist of just the few staff ranks is a lot easier then. |
@JRoy Any input on this? If you agree with the whitelist suggestion I can implement it and finalise this PR |
Sorry, though I had replied, still convinced that a blacklist would be more useful by default. You can add a boolean config option |
Yeah a blacklist by default is fine, I'll add a boolean thank you. Will modify the PR when I have the chance |
…5157) Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Information
This PR partially closes #5155
Details
Proposed feature:
Add options to only select certain Discord roles and to add aliases for roles.
This is parallel to the
DiscordChatChannelRoleAliases
andDiscordChatChannelRolesSelection
options in DiscordSRV.This can be used to ignore certain roles, by only selecting roles relating to Minecraft to be processed by the plugin.
The aliases allow for mapping names in Discord to in Minecraft. For example "Admins" can be mapped to "Admin". This can also be used to hardcode which colour a role should be in Minecraft by setting the alias to include a colour code for example: "§9Admin"
Environments tested:
OS: Fedora 36
Java version:
17.0.5
Don't see how this could differ on other server versions.
Demonstration:
The


Founder
role gets ignored and theAdmins
role gets translated to§9Admin