Add /mail clear <player> and /mail clearall commands #4878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pop4959
added
type: enhancement
|
I'm sorry, I'm still kind of new to GitHub. Is there something I need to do to get this approved? |
We haven't had the time to review this PR yet. Once the 1.19 update is finished, we'll start reviewing PRs that add new features. |
mdcfe
previously requested changes
Aug 16, 2022
Essentials/src/main/java/com/earth2me/essentials/commands/Commandmail.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/commands/Commandmail.java
Outdated
Show resolved
Hide resolved
new clearMail function returns user used on to make it easier to send the return message back to the correct source.
|
Alright, I believe I did what you asked. To make it easier to display the user the clear command was used on, I set the clearMail() command to return that User object so I can include their name in the message. |
|
Thought I'd give this a poke. Not sure if I have to do anything from here. |
JRoy
approved these changes
Aug 8, 2023
JRoy
changed the title
Starmism
pushed a commit
to valence-smp/Essentials
that referenced
this pull request
Jan 8, 2025
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR closes #2057.
Details
Proposed feature:
/mail clear [player] and /mail clearall. Functions on online and offline players, and clears their mailboxes. Adds permissions essentials.mail.clear.others and essentials.mail.clearall.
Note; please look closely at my code. This is one of my first times working on a GitHub project, so I want to be sure I'm not breaking anything and that I'm doing it right.
Environments tested:
OS: Windows 11
Java version: Java(TM) SE Runtime Environment (build 17.0.1+12-LTS-39)
Demonstration:
Before /mail clearall:
After /mail clearall:
Before /mail clear [player]:
After /mail clear [player]:
