Add support for commands.yml aliases in command cooldowns #3744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwoo1110
reviewed
Oct 26, 2020
Essentials/src/com/earth2me/essentials/EssentialsPlayerListener.java
Outdated
Show resolved
Hide resolved
FrankHeijden
force-pushed
the
fix/alias-command-cooldown
branch
from
2dce671 to
39f2f4f
Compare
|
Took a look at this real quick but doesn't seem like it's working. Have you tested this? If so, can you provide any manual test cases you tried and their output? |
FrankHeijden
force-pushed
the
fix/alias-command-cooldown
branch
from
39f2f4f to
60db00a
Compare
It was working, however we had to explicitly define an extra cooldown for the alias as well in the essentials This built was tested on paper 1.8.8, paper 1.16.3 and spigot 1.16.3. |
FrankHeijden
changed the title
FrankHeijden
changed the title
Chew
added
the
status: needs manual rebase
|
Hello, can you please rebase this pull request so we can merge it! Thanks! |
FrankHeijden
force-pushed
the
fix/alias-command-cooldown
branch
from
e3aae13 to
e637e66
Compare
Alright! Should be good to go now! Sorry I didn't notice it earlier, totally slipped my mind. |
Chew
removed
the
status: needs manual rebase
JRoy
requested changes
Jan 3, 2021
- Split the provider up for both spigot/paper impl.
FrankHeijden
force-pushed
the
fix/alias-command-cooldown
branch
from
1a8d3dc to
b6c5cc3
Compare
# Conflicts: # providers/PaperProvider/build.gradle
# Conflicts: # providers/PaperProvider/build.gradle
# Conflicts: # Essentials/src/main/java/com/earth2me/essentials/Essentials.java
FrankHeijden
force-pushed
the
fix/alias-command-cooldown
branch
from
0e65970 to
cd4007b
Compare
mdcfe
requested changes
Feb 5, 2021
Essentials/src/main/java/com/earth2me/essentials/Essentials.java
Outdated
Show resolved
Hide resolved
mdcfe
previously approved these changes
Feb 5, 2021
JRoy
reviewed
Feb 5, 2021
...ionProvider/src/main/java/net/ess3/nms/refl/providers/ReflFormattedCommandAliasProvider.java
Outdated
Show resolved
Hide resolved
JRoy
reviewed
Feb 5, 2021
...ovider/src/main/java/net/ess3/provider/providers/PaperReflFormattedCommandAliasProvider.java
Outdated
Show resolved
Hide resolved
Removing PaperReflFormattedCommandAliasProvider.java and the need for the reflection library in paper providers.
|
Done, should be good to go 😄 |
JRoy
requested changes
Feb 6, 2021
providers/BaseProviders/src/main/java/net/ess3/provider/FormattedCommandAliasProvider.java
Outdated
Show resolved
Hide resolved
...ionProvider/src/main/java/net/ess3/nms/refl/providers/ReflFormattedCommandAliasProvider.java
Outdated
Show resolved
Hide resolved
…ndAliasProvider an interface
mdcfe
approved these changes
Feb 20, 2021
mdcfe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens for example with commands.yml, the aliases defined in there don't have a PluginCommand instance.