Skip to content
This repository has been archived by the owner on Apr 26, 2023. It is now read-only.

Support attachments for php5.6+, #364 #365

Merged
merged 1 commit into from
Feb 5, 2018
Merged

Support attachments for php5.6+, #364 #365

merged 1 commit into from
Feb 5, 2018

Conversation

bsvensson
Copy link
Member

@bsvensson bsvensson commented May 31, 2016

Tested locally with php 5.5 and php 7.0.0

@bsvensson bsvensson added this to the 1.1.1 milestone May 31, 2016
@phpmaps
Copy link

phpmaps commented Jun 16, 2016

@bsvensson @esoekianto - I tested this fix. The file gets there, but something strange is happening. The uploaded file on my machine swaps out the file name for the file name + path on my personal computer. So the file attachment name will become something like this :

/private/var/tmp/Celebrate1.png

Also the ArcGIS machine receiving the attachment does not assign the proper mime type. So when I go to click on the attachment it automatically does a download vs a preview in the browser. My test results below.

{"attachmentInfos":[{"id":2947,"parentObjectId":111,"name":"/private/var/tmp/Celebrate1.png","contentType":"application/octet-stream","size":317839}]} 

@phpmaps
Copy link

phpmaps commented Jun 16, 2016

@bsvensson I should have said the above test results were for 5.5.7. So maybe I should disregard and test with another PHP version?

@bsvensson
Copy link
Member Author

@phpmaps - if you're testing with pre-5.6 then the behavior should be the same with or without this fix.

@bsvensson bsvensson removed this from the 1.1.1 milestone Feb 5, 2018
@bsvensson bsvensson merged commit 2353719 into master Feb 5, 2018
@bsvensson bsvensson deleted the attachments-5.6 branch February 6, 2018 01:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants