Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils: improve logging #30

Closed
mistafunk opened this issue Apr 25, 2016 · 4 comments · Fixed by #155
Closed

utils: improve logging #30

mistafunk opened this issue Apr 25, 2016 · 4 comments · Fixed by #155
Labels
enhancement underspecified
Milestone
v1.8.0

Comments

@mistafunk
Copy link
Collaborator

currently, the sop uses global logging levels (fatal, error, warn, info, debug) inherited from CE SDK. this is problematic for large scenes where some rpks emit a lot of cga warnings/errors -> log flood & huge slowdown!

this needs a proper spec, i.e.

  • CGA errors / asset issues should be collected separately and be inspectable (cf CE problems view)
  • each initial shape should have a logging control to debug [confirm this, is this a good idea?]
@mistafunk mistafunk added this to the v1.0 (private beta) milestone Apr 25, 2016
@MattB3D
Copy link

MattB3D commented Apr 26, 2016

can you first make a list of all types of errors?
e.g. CGA, SDK, Houdini C++, Houdini Python, ..

also, instead of putting all in one console, is following possible?

  • multiple consoles?
  • log files?

@mistafunk mistafunk modified the milestones: v0.9 (private beta), v1.0, v0.8 (internal alpha) Dec 23, 2016
@mistafunk mistafunk modified the milestones: v0.8 (internal alpha), v0.9 (private beta) Nov 26, 2017
@mistafunk mistafunk changed the title [spec needed] improve logging utils: improve logging Nov 27, 2017
@mistafunk mistafunk removed this from the v0.9 (private beta) milestone Nov 27, 2017
@mistafunk mistafunk added this to the v1.8.0 milestone Jun 14, 2020
@mistafunk
Copy link
Collaborator Author

  • we should have log level (including turn off logging) per generate node.
  • all nodes should log into the same file prefixed with the generate node name.

@mistafunk
Copy link
Collaborator Author

default log level per generate node = error

mistafunk added a commit that referenced this issue Aug 23, 2020
@mistafunk
#30: introduce log level parameter
361f3a4
mistafunk added a commit that referenced this issue Aug 23, 2020
@mistafunk
#30: clarify function name to get initial log level
193c306
mistafunk added a commit that referenced this issue Aug 23, 2020
@mistafunk
#30: move getDefaultLogLevel to logging namespace
0391a03
mistafunk added a commit that referenced this issue Aug 23, 2020
@mistafunk
#30: add helper function to get per-node log level
eafc023
mistafunk added a commit that referenced this issue Aug 23, 2020
@mistafunk
#30: added RAII-style log level modifier
28fe11d
mistafunk added a commit that referenced this issue Aug 23, 2020
@mistafunk
#30: override log level per node
405d7f8
@mistafunk mistafunk linked a pull request Aug 23, 2020 that will close this issue
Logging per node #155
Merged
@mistafunk
Copy link
Collaborator Author

implemented & merged basic feature (no writing to log files yet)

mistafunk added a commit that referenced this issue Aug 23, 2020
@mistafunk
Updated change log for #30
8630f64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement underspecified
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging a pull request may close this issue.

Logging per node Esri/palladio
2 participants
@mistafunk @MattB3D