Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated web-adapter name #10581

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix: updated web-adapter name #10581

merged 2 commits into from
Oct 23, 2024

Conversation

arowles
Copy link
Contributor

@arowles arowles commented Oct 22, 2024

Related Issue: #

Summary

updated

web-adaptor > web-adapter

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Oct 22, 2024
@calcite-admin calcite-admin added the skip visual snapshots Pull requests that do not need visual regression testing. label Oct 22, 2024
@arowles arowles merged commit fc1b875 into dev Oct 23, 2024
13 checks passed
@arowles arowles deleted the arowles/rename-pin-icons branch October 23, 2024 16:58
@github-actions github-actions bot added this to the 2.13.2 patch milestone Oct 23, 2024
@jcfranco
Copy link
Member

@arowles @aphilobos web-adaptor is available in version 3.32.0, so this rename would be a breaking change. Developers currently using this icon (example) would need to update their code, or their icons will stop displaying.

Consider reverting or restoring the icon + deprecating it instead.

cc @benelan

@arowles
Copy link
Contributor Author

arowles commented Oct 23, 2024

@jcfranco After reverting the icon, how would I deprecate it?

@jcfranco
Copy link
Member

Good question, not sure if there's a mechanism for this yet in the icon doc page. Would it possible to use a keyword or some other type of metadata to mark it as deprecated and have it show up in the doc? @benelan Any other ideas?

For clarification, are you thinking about:

  1. reverting web-adapter back to web-adaptor, mark it as deprecated and do the rename and removal later or
  2. restoring web-adaptor (alongside web-adapter) and mark it as deprecated and remove later

?

benelan added a commit that referenced this pull request Oct 25, 2024
…orepo

* origin/dev:
  build(deps): update typescript-eslint monorepo to v7.18.0 (#10593)
  feat(tile): add design tokens (#10476)
  deprecate: deprecate web-adaptor in favor of web-adapter (#10598)
  docs: update component READMEs (#10600)
  build(deps): update dependency @rollup/plugin-replace to v6 (#10604)
  chore: release main (#10597)
  ci(chromatic): build storybook even when skipping snapshots (#10589)
  build(deps): update dependency axe-core to v4.10.1 (#10566)
  ci: add calcite-ui-icons label to relevant package PRs (#10590)
  chore: release next
  feat: add buffer point, buffer polygon, buffer polyline, contour, offset (#10594)
  feat(input-date-picker, date-picker): improve date picking experience (#8402)
  chore: release next
  fix: updated web-adapter name (#10581)
  build(deps): update nrwl monorepo to v19.8.6 (#10575)
  build(deps): update dependency tsx to v4.19.1 (#10574)
  build(deps): update dependency @cspell/eslint-plugin to v8.15.4 (#10565)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants