Edit features with feature-linked annotation implementation

[vquach2404]

Implementation of Edit features with feature-linked annotation implementation. Looking forward to feedback!

[yo1995]

Thanks for implementing this sample! There are a few things to fix and to discuss. I can give another review before getting to Phil.

[yo1995]

I think it's OK to keep them private, but Phil might ask to remove them. Let's wait for his response.

[vquach2404]

@yo1995 Thanks for the suggestions! I made some changes and it is ready for another review.

[yo1995]

For the identify workflow, here is my version

        mapView.identifyLayers(atScreenPoint: screenPoint, tolerance: 10.0, returnPopupsOnly: false) { (results: [AGSIdentifyLayerResult]?, error: Error?) in
            if let error = error {
                self.presentAlert(error: error)
                return
            }
            results?.forEach { (result) in
                guard let featureLayer = result.layerContent as? AGSFeatureLayer, let featureToSelect = result.geoElements[0] as? AGSFeature else { return }
                switch featureToSelect.geometry?.geometryType {
                case .point:
                    self.showEditableAttributes(selectedFeature: featureToSelect)
                case .polyline:
                    let polyline = featureToSelect.geometry as! AGSPolyline
                    let polylineArray = polyline.parts.array()
                    for part in polylineArray {
                        if part.pointCount > 2 {
                            self.selectedFeature = nil
                            self.presentAlert(title: "Make a different selection", message: "Select straight (single segment) polylines only.")
                            return
                        }
                    }
                    self.selectedFeatureIsPolyline = true
                default:
                    return
                }
                featureLayer.select(featureToSelect)
                self.selectedFeature = featureToSelect
            }
        }

This includes all the suggestion I made in early reviews. Feel free to make some changes.

As the day is coming to an end, I'll leave more comments tomorrow. 👋

[yo1995]

A few small issues. Ready for Phil's review! 👍

[philium]

@vquach2404 Looks good! Thanks for making all those changes. This is now ready for @saratchandrakarumuri to look at.

[saratchandrakarumuri]

None of the edits are getting save

• If I change attributes on point feature, they are not reflected in the respective annotation
• If I try to move a line segment feature, I get this error

[yo1995]

@saratchandrakarumuri Just now I gave it a test and it seems to work fine. Are you using the geodatabase file downloaded by the sample viewer? We are not sure what caused this problem. 🤔

[saratchandrakarumuri]

@yo1995 I cleared downloaded geodatabase and tried again with fresh install and ran into it again on couple of devices. But the same thing worked on a sim. So looks like the issue is exclusive with physical devices

[philium]

@vquach2404 The location of the geodatabase is readonly on device. I didn't think about that. To fix that, you'll need to copy the geodatabase into a temporary directory. Here is how one sample does the same thing with a mobile map package.

[yo1995]

@vquach2404 With this change, the edits are not persisted from session to session as the temp replica is removed after deinit. Should we mention in README?

[yo1995]

The updates LGTM. Looking forward to Sarat's re-review.

[vquach2404]

@vquach2404 With this change, the edits are not persisted from session to session as the temp replica is removed after deinit. Should we mention in README?

I don't think this is necessary since most samples behave similarly (e.g. a sample refreshing to a default layer after previously selecting different layers) and the geodatabase is not an online source.

[saratchandrakarumuri]

Now I am able to edit features. Sample is working as expected