This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
New: Configure subnetwork trace #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igureSubnetwork_vNext # Conflicts: # arcgis-ios-sdk-samples.xcodeproj/project.pbxproj
…igureSubnetwork_vNext # Conflicts: # arcgis-ios-sdk-samples.xcodeproj/project.pbxproj
This reverts commit db126eb.
This file was added as a result of a SourceTree commit. Removed because it's not in v.next.
|
I made additional commits after requesting reviews to fix the project files. But now they are fixed and ready for reviews 🙂 |
philium
reviewed
Sep 8, 2020
...ility Network/Configure subnetwork trace/ConfigureSubnetworkTraceOptionsViewController.swift
Outdated
Show resolved
Hide resolved
...ility Network/Configure subnetwork trace/ConfigureSubnetworkTraceOptionsViewController.swift
Outdated
Show resolved
Hide resolved
...ility Network/Configure subnetwork trace/ConfigureSubnetworkTraceOptionsViewController.swift
Outdated
Show resolved
Hide resolved
yo1995
previously approved these changes
Sep 9, 2020
...ples/Utility Network/Configure subnetwork trace/ConfigureSubnetworkTraceViewController.swift
Show resolved
Hide resolved
yo1995
previously approved these changes
Sep 9, 2020
|
@philium This is ready for another review! |
While I'm playing it on smallest SE, it seems the text get clipped. I believe other previous samples might also have this problem, but should we use dynamic font size (i.e. auto shrinking) for the cell label? |
philium
suggested changes
Sep 10, 2020
...ility Network/Configure subnetwork trace/ConfigureSubnetworkTraceOptionsViewController.swift
Show resolved
Hide resolved
yo1995
approved these changes
Sep 10, 2020
philium
approved these changes
Sep 10, 2020
|
@saratchandrakarumuri Please take a look at this new sample. 😃 |
saratchandrakarumuri
approved these changes
Sep 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experimented with different types of iOS UI that were new to me. Looking forward to feedback!