fix(arcgis-rest-request): appendCustomParams strips valid options #1221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinr-maps
approved these changes
Apr 30, 2025
|
Released in v4.4.2. |
tomwayson
pushed a commit
that referenced
this pull request
Apr 30, 2025
## @esri/arcgis-rest-request [4.4.2](https://github.com/Esri/arcgis-rest-js/compare/@esri/arcgis-rest-request@4.4.1...@esri/arcgis-rest-request@4.4.2) (2025-04-30) ### Bug Fixes * **arcgis-rest-request:** appendCustomParams strips valid options ([#1221](#1221)) ([bd1aa9c](bd1aa9c))
COV-GIS
pushed a commit
to COV-GIS/arcgis-rest-js
that referenced
this pull request
Apr 30, 2025
## [4.6.1](https://github.com/Esri/arcgis-rest-js/compare/@esri/arcgis-rest-portal@4.6.0...@esri/arcgis-rest-portal@4.6.1) (2025-04-30) ### Bug Fixes * restore IUserRequestOptions.authentication: ArcGISIdentityManager ([057edf0](Esri@057edf0)) * **arcgis-rest-request:** appendCustomParams strips valid options ([Esri#1221](Esri#1221)) ([bd1aa9c](Esri@bd1aa9c)) * postMessage must send a Credential that is usable by JSSDK ([Esri#1223](Esri#1223)) ([082b1c6](Esri@082b1c6)) * restore IUserRequestOptions.authentication to a ArcGISIdentityManager ([4c528ba](Esri@4c528ba)) ### Features * **arcgis-rest-request:** change getDomainCredentials to handle URLs with mismatching cases ([013e4da](Esri@013e4da)) * **arcgis-rest-request:** switched to using toLowerCase ([7ae474b](Esri@7ae474b)) ### Reverts * **arcgis-rest-feature-service:** service def fns take IAuthenticatedRequestOptions ([4471fff](Esri@4471fff))
patrickarlt
pushed a commit
to KarshitShah/arcgis-rest-js
that referenced
this pull request
Aug 14, 2025
## [4.1.1](https://github.com/Esri/arcgis-rest-js/compare/@esri/arcgis-rest-feature-service@4.1.0...@esri/arcgis-rest-feature-service@4.1.1) (2025-08-13) ### Bug Fixes * Add typings for IAddItem, GetItemResources, and ILayerDefinition ([Esri#1241](Esri#1241)) ([604c2d9](Esri@604c2d9)) * **arcgis-rest-basemap-sessions:** improve logic for duration and safetyMargin ([9384113](Esri@9384113)) * **arcgis-rest-basemap-sessions:** wrap up work before removing local options ([f5d5c60](Esri@f5d5c60)) * **arcgis-rest-request:** appendCustomParams strips valid options ([7fbfca6](Esri@7fbfca6)) * **arcgis-rest-request:** isSameOrigin returns false when url arg is null ([Esri#1240](Esri#1240)) ([6e3c94b](Esri@6e3c94b)) * actually export no-cors utils ([746429e](Esri@746429e)) * package-lock that should have been checked in after release ([78baaf1](Esri@78baaf1)) * **arcgis-rest-request:** appendCustomParams strips valid options ([Esri#1221](Esri#1221)) ([bd1aa9c](Esri@bd1aa9c)) * **arcgis-rest-request:** parentMessageHandler handles ICredential or IArcGISIdentityManagerOptions ([ae8159b](Esri@ae8159b)) * **arcgis-rest-request:** postMessage auth works w/ credential ([cfa57e9](Esri@cfa57e9)) * postMessage must send a Credential that is usable by JSSDK ([Esri#1223](Esri#1223)) ([082b1c6](Esri@082b1c6)) * restore IUserRequestOptions.authentication to a ArcGISIdentityManager ([4c528ba](Esri@4c528ba)) * restore IUserRequestOptions.authentication: ArcGISIdentityManager ([057edf0](Esri@057edf0)) ### Features * **arcgis-rest-basemap-sessions:** add basemap style sessions package ([ec63c02](Esri@ec63c02)) * **arcgis-rest-basemap-sessions:** remove static basemap tiles ([7c1ec7f](Esri@7c1ec7f)) * add basemap session package ([b8848e1](Esri@b8848e1)) * integrate no-cors into request fn ([f828bab](Esri@f828bab)) * no-cors utils and global cache ([29db594](Esri@29db594)) * setup vitest ([81cd426](Esri@81cd426)) * **arcgis-rest-developer-credentials:** add invalidateApiKey, fix generate API key bug ([b1458a2](Esri@b1458a2)) * **arcgis-rest-elevation:** initial release of elevation package ([Esri#1191](Esri#1191)) ([0d2064c](Esri@0d2064c)) * **arcgis-rest-places:** places api - add icon param ([203821d](Esri@203821d)), closes [Esri#1175](Esri#1175) [Esri#1175](Esri#1175) [Esri#1183](Esri#1183) * **arcgis-rest-portal:** add removeItemThumbnail() to delete item thumbnails ([Esri#1202](Esri#1202)) ([a1b51f3](Esri@a1b51f3)) * **arcgis-rest-request:** add option to override request function ([cd3948b](Esri@cd3948b)) * **arcgis-rest-request:** add serialization and deserialization for all auth managers ([d85f595](Esri@d85f595)) * **arcgis-rest-request:** change getDomainCredentials to handle URLs with mismatching cases ([013e4da](Esri@013e4da)) * **arcgis-rest-request:** switched to using toLowerCase ([7ae474b](Esri@7ae474b)) * make API keys work with all portal methods ([Esri#1186](Esri#1186)) ([1972413](Esri@1972413)) ### Reverts * **arcgis-rest-feature-service:** service def fns take IAuthenticatedRequestOptions ([4471fff](Esri@4471fff)) * feat(arcgis-rest-developer-credentials)!: export slot helper ([ba33510](Esri@ba33510)) ### BREAKING CHANGES * requires additional changes to API key method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestOptionsKeyswere not in sync w/IRequestOptions, which caused valid options to be stripped from the options.