Skip to content

Conversation

@kapil-varshney
Copy link
Contributor

This adds the Deep Learning - Faster R-CNN guide.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@vikashranjan26 vikashranjan26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priyankatuteja
Copy link
Collaborator

As discussed please make the following minor changes related to paper citation. @BP-Ent Could you do the review too.

Copy link
Collaborator

@BP-Ent BP-Ent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes made on ReviewNB

@priyankatuteja priyankatuteja added the changes requested remove this label after addressing reviewer comments label Jan 13, 2021
@priyankatuteja priyankatuteja added approved PR approved by reviewer and removed changes requested remove this label after addressing reviewer comments labels Jan 19, 2021
@@ -0,0 +1,190 @@
{
Copy link
Contributor

@AtmaMani AtmaMani Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace title to read the title of the page. We need this so the browser tab, SE indexers get them correctly


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a title to the guide with the same name as the notebook file. Does this help?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, thanks

Copy link
Contributor

@AtmaMani AtmaMani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested update to title

@AtmaMani AtmaMani added changes requested remove this label after addressing reviewer comments and removed approved PR approved by reviewer labels Jan 21, 2021
@AtmaMani AtmaMani merged commit 8a3de7c into master Jan 22, 2021
@AtmaMani AtmaMani added approved PR approved by reviewer and removed changes requested remove this label after addressing reviewer comments labels Jan 23, 2021
@mohi9282 mohi9282 added the added to build Label to identify PRs that have been added to local build for Dev Site label Jan 23, 2021
@AtmaMani AtmaMani deleted the fasterrcnn-guide branch January 10, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to build Label to identify PRs that have been added to local build for Dev Site approved PR approved by reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants