Skip to content

Conversation

@mohi9282
Copy link
Contributor

Resolves issue #4472 by adding 5 data engineering guide notebooks.

Resolves issue #4472 by adding 5 data engineering guide notebooks.
@mohi9282 mohi9282 added the documentation Bugs and enhancement requests for doc (API ref and notebooks) label Nov 25, 2020
@mohi9282 mohi9282 added this to the 1.8.3 release milestone Nov 25, 2020
@mohi9282 mohi9282 requested a review from AtmaMani November 25, 2020 22:27
@mohi9282 mohi9282 self-assigned this Nov 25, 2020
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@AtmaMani AtmaMani requested a review from BP-Ent November 25, 2020 22:57
@AtmaMani
Copy link
Contributor

@BP-Ent could you please review this PR?

Updates samples per feedback from Breck
@mohi9282
Copy link
Contributor Author

mohi9282 commented Dec 4, 2020

@BP-Ent thanks for taking the time to review the guides.

@AtmaMani I have incorporated the changes recommended by Breck.

Attaching Breck's feedback doc here:

breck_review.docx

@@ -0,0 +1,1637 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the first paragraph, we need to say that SeDF is a capability that is added to a regular Pandas DataFrame by the ArcGIS API for Python.

In the last sentence of this paragraph, we can add that what is shown below is just a quickstart to SeDF and in subsequent pages of the guide, SeDF will be dealt with in a detailed manner


Reply via ReviewNB

@AtmaMani
Copy link
Contributor

@mohi9282 thanks for the comprehensive primer for data engineering. I have asked for a minor text addition in notebook 1. @BP-Ent thanks for the detailed reviews (offline).

@AtmaMani AtmaMani added the changes requested remove this label after addressing reviewer comments label Dec 14, 2020
@mohi9282
Copy link
Contributor Author

Hi @AtmaMani - I have made the suggested changes.

@AtmaMani AtmaMani merged commit 4915223 into Esri:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes requested remove this label after addressing reviewer comments documentation Bugs and enhancement requests for doc (API ref and notebooks)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants