designate bike routes

[priyankatuteja]

• All imports are in the first cell? First block of imports are standard libraries, second block are 3rd party libraries, third block are all arcgis imports?
• All GIS object instantiations are one of the following?
  • gis = GIS('https://www.arcgis.com', 'arcgis_python', 'P@ssword123')
  • gis = GIS(profile="your_online_profile")
  • gis = GIS('https://pythonapi.playground.esri.com/portal', 'arcgis_python', 'amazing_arcgis_123')
  • gis = GIS(profile="your_enterprise_portal")
• If this notebook requires setup or teardown, did you add the appropriate code to ./misc/setup.py and/or ./misc/teardown.py?
• If this notebook references any portal items that need to be staged on AGOL/Python API playground, did you coordinate with a Python API team member to stage the item the correct way with the api_data_owner user?
• Code refactored & split out across multiple cells, useful comments?
• Consistent voice/tense/narrative style? Thoroughly checked for typos?
• All images used like <img src="base64str_here"> instead of <img src="https://some.url">? All map widgets contain a static image preview? (Call mapview_inst.take_screenshot() to do so)
• All file paths are constructed in an OS-agnostic fashion with os.path.join()? (Instead of r"\foo\bar", os.path.join(os.path.sep, "foo", "bar"), etc.)

[review-notebook-app]

Check out this pull request on ReviewNB: https://app.reviewnb.com/Esri/arcgis-python-api/pull/453

Visit www.reviewnb.com to know how we simplify your Jupyter Notebook workflows.

[achapkowski]

@priyankatuteja The table of contents is not rendering correctly, can you please check the syntax.

[priyankatuteja]

It seems fine on this link https://github.com/Esri/arcgis-python-api/blob/b9abba304ffa72c98fe96afd120781f64cbe0920/samples/04_gis_analysts_data_scientists/designate_bike_routes_for_commuting_professionals.ipynb

It could be a reviewnb bug.

[Yongyao]

LGTM. Thanks @priyankatuteja