Skip to content

Remove secrets #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove secrets #190

wants to merge 1 commit into from

Conversation

airaolagoitia
Copy link
Collaborator

Sample

Remove secrets

Checklist

  • PR title follows convention - keyword: Short description of change
  • PR targets the correct branch
  • Self-review of changes
  • There are no warnings related to changes
  • A build was made and tested on all relevant platforms
  • No unrelated changes have been made to any other code or project files
  • No unnecessary includes or namespaces added
  • Code follows plugin coding style
  • New code and changed code has proper formatting
  • No unintentional formatting changes
  • Commits have descriptive titles

ArcGIS Maps SDK Version

@airaolagoitia airaolagoitia self-assigned this Aug 26, 2025
SamCartledge
SamCartledge approved these changes Aug 27, 2025
View reviewed changes
Copy link
Collaborator

@SamCartledge SamCartledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rewrite commit history on these files?

@Jade-JadeH
Copy link
Collaborator

Should we rewrite commit history on these files?

thought the same...

@SamCartledge
Copy link
Collaborator

Do we want to get this merged and history squashed so we can continue with enabling security?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamCartledge SamCartledge SamCartledge approved these changes

@Jade-JadeH Jade-JadeH Jade-JadeH approved these changes

@mmgaw113 mmgaw113 mmgaw113 approved these changes

@darn darn Awaiting requested review from darn

Assignees

@airaolagoitia airaolagoitia

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@airaolagoitia @Jade-JadeH @SamCartledge @mmgaw113