Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sample viewer build "Visualization" category crash #138

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

prupani-7
Copy link

@prupani-7 prupani-7 commented Oct 4, 2023

Sample viewer build sample category crash:
Fixes an error with sample viewer build caused by the feature reduction metadata file, with the order of the images file names.
Ran the sample viewer app, with this change to verify, and the Visualization category doesnt crash anymore.

Copy link
Collaborator

@shubham7109 shubham7109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 seems like we need to keep in mind to use the main screenshot as the first image when using multiple screenshots.

@prupani-7 prupani-7 merged commit 7733125 into v.next Oct 4, 2023
1 check failed
@prupani-7 prupani-7 deleted the fix-sample-viewer-build-error branch October 4, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants