Venkata/display scene from mobile scene package #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham7109
requested changes
Jul 24, 2023
There was a problem hiding this comment.
Looks good @vbharath98, very impressive work here! Sample works as expected, just a few comments to help optimize the code and use patterns similar to other samples.
Once you have the changes in we can take a look at the Github checker to see if any warnings pop up, and we could resolve them in the next review.
.../src/main/java/com/esri/arcgismaps/sample/displayscenefrommobilescenepackage/MainActivity.kt
Outdated
Show resolved
Hide resolved
...a/com/esri/arcgismaps/sample/displayscenefrommobilescenepackage/components/SceneViewModel.kt
Outdated
Show resolved
Hide resolved
...a/com/esri/arcgismaps/sample/displayscenefrommobilescenepackage/components/SceneViewModel.kt
Outdated
Show resolved
Hide resolved
...a/com/esri/arcgismaps/sample/displayscenefrommobilescenepackage/components/SceneViewModel.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/esri/arcgismaps/sample/displayscenefrommobilescenepackage/screens/MainScreen.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/esri/arcgismaps/sample/displayscenefrommobilescenepackage/screens/MainScreen.kt
Show resolved
Hide resolved
This reverts commit 79ba36a.
…ps://github.com/Esri/arcgis-maps-sdk-kotlin-samples into venkata/display_scene_from_mobile_scene_package
shubham7109
approved these changes
Jul 24, 2023
eri9000
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to add a new Kotlin sample "Display a scene from a mobile scene package" in
Edit and Manage Datacategory.Links and Data
Task Link:
runtime/kotlin/issues/2570What To Review
README.mdandREADME.metadata.jsonfilesHow to Test
Run the sample on the sample viewer or the repo.